AO3-7568 Fix error 500 when importing a work with a numeric date

[hab-bang]

Pull Request Checklist

• Have you read the contributing guidelines?
• Have you read "How to write the perfect pull request"?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait until they are reviewed and merged before creating new pull requests.
• I acknowledge that submitting code created or modified with the help of AI is a bannable offense.

Issue

https://otwarchive.atlassian.net/browse/AO3-7568

Purpose

Fixing the misspelled constant in StoryParser#convert_revised_at that returns an Error 500 when a work's date is a plain number.

The method treats an all-digit date as seconds since the epoch. That branch calls Regex.last_match, but the class is Regexp, so it raises uninitialized constant StoryParser::Regex. The method only rescues ArgumentError and TypeError, so the error escapes the import and the user gets a 500.

Testing Instructions

Follow the reproduction steps on the Jira issue (Post > Import Work with the gist URL from the ticket, and any language):

• Before this change: Error 500 (NameError: uninitialized constant StoryParser::Regex).
• After this change: the work imports and you get the work preview.

The date shows as 1970-01-04, because the parser reads an all-numeric date as a Unix timestamp. That is existing behaviour and is not changed here, so it is expected.

Full testing instructions are also on the Jira ticket.

References

Reported from Sentry, issue AO3-STAGING-8Y.

Credit

Name: Woo Hayoung
Pronouns: she/her

[sarken]

Hi, hayoung!

Thanks for working on this. It looks like this was submitted with an outdated version of the pull request template. Before we review this, could you take a moment to edit the description to use the new Pull Request Checklist, which includes a new checkbox about our AI policy? The new template is here: https://github.com/otwcode/otwarchive/blob/master/.github/PULL_REQUEST_TEMPLATE.md

Thanks!

[hab-bang]

Hi, hayoung!

Thanks for working on this. It looks like this was submitted with an outdated version of the pull request template. Before we review this, could you take a moment to edit the description to use the new Pull Request Checklist, which includes a new checkbox about our AI policy? The new template is here: https://github.com/otwcode/otwarchive/blob/master/.github/PULL_REQUEST_TEMPLATE.md

Thanks!

Hi @sarken ! Firstly I'm sorry for using the old template; I didn't realize that the template has been updated and I still used the same one I used for my first PR. My apologies!

I have updated my PR description and included the checkbox about the AI policy, and I can confirm that I do not submit the code with the help of AI.

If you have questions or other stuff related to this PR that you want me to work on, please let me know!

[redsummernight]

Can you call the method instead of using send?

@sp.convert_revised_at("300106")

[hab-bang]

@redsummernight thank you for the review--it means I'll have to modify the before(:all) and after(:all) to make the method public and then back to protected. Working on this now.

[redsummernight]

I see now why you opted for send. Looks good, thank you!

[hab-bang]

Thank you so much @redsummernight !