AO3-7222 Check can_change_username to show Rename button for admin - #5989
AO3-7222 Check can_change_username to show Rename button for admin#5989Panekd wants to merge 2 commits into
Conversation
|
Hi, Rose Hardy! Thank you so much for this pull request. Someone will be along to review it soon. In the meantime, I've updated the Jira issue status to In Review so no one mistakenly creates a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)." Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you. Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above. |
danderson
left a comment
There was a problem hiding this comment.
I'm just an onlooker, but the change looks good to me.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
AO3-7222
Purpose
Add a check of can_rename_user to show Rename button on user administration page so it is only shown to admins with permission to rename users
Testing Instructions
See Jira
Credit
Rose Hardy - she/her