AO3-7382 Making the history page for a nonexistent user show an error 404 instead of redirecting - #5990
Open
ASalbenblatt wants to merge 6 commits into
Conversation
…ing at a non-existent user's page
…hboard when looking at a non-existent user's page
sarken
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7382
Purpose
When visiting the history page of a nonexistent user, it used to redirect you to a page saying "Sorry, you don't have permission...", but since the page is in fact nonexistent, it now instead redirects to a 404 page, and only existing users you don't have permission to view redirect to the "Sorry, you don't have permission..." page.
I also i18n-ed the history page's controller while I was at it.
Testing Instructions
In addition to the test in Jira:
Credit
FlyingFalcon (they/them)