Skip to content

AO3-7582 i18n-ing the csv download help file - #5991

Open
ASalbenblatt wants to merge 2 commits into
otwcode:masterfrom
ASalbenblatt:AO3-7582-i18n-csv-download-help-file
Open

AO3-7582 i18n-ing the csv download help file#5991
ASalbenblatt wants to merge 2 commits into
otwcode:masterfrom
ASalbenblatt:AO3-7582-i18n-csv-download-help-file

Conversation

@ASalbenblatt

Copy link
Copy Markdown
Contributor

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7582

Purpose

This internationalizes the csv-download help file

Credit

FlyingFalcon (they/them)

@danderson danderson left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with the codebase. The change seems reasonable, but a couple of the i18n labels have a typo.

Comment thread app/views/challenge/shared/_challenge_requests.html.erb Outdated
Comment thread app/views/challenge/prompt_meme/_challenge_signups.html.erb Outdated
@ASalbenblatt

Copy link
Copy Markdown
Contributor Author

Thanks for catching that, I think I misspelled it once and then copy and pasted it around because I made the same mistake in all four csv_downlaod_help_titles lol, should be fixed now though

@danderson danderson left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants