AO3-4052 Require choosing a pseud option when orphaning - #6009
Open
pmonfort wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
AO3-1234 Fix thing)Issue
https://otwarchive.atlassian.net/browse/AO3-4052
Purpose
The orphan page preselected "Take my pseud off as well", so it was easy to orphan without reading the options. This PR:
OrphansController#createreject the form when no option (or an unexpected value) is submitted, with an error and a redirect back to the orphan page.legendfor screen readers, following the pattern used in the work form.The partial is shared by the work, series, pseud and account orphan pages, so all four are affected.
Testing Instructions
<pseud> (orphan_account)in the byline, unless the work is in an anonymous collection).orphan_account.Credit
Pablo Monfort (he/him)