chore(ci): handle version degeneracy nicely#1610
Merged
Merged
Conversation
If there are no substantive commits, git cliff doesn't bump the version, but the script worked on the assumption there is always a change. Signed-off-by: JP-Ellis <josh@jpellis.me>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1610 +/- ##
====================================
Coverage 74% 74%
====================================
Files 36 36
Lines 4012 4012
====================================
Hits 2984 2984
Misses 1028 1028
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the release automation to treat “version degeneracy” from git cliff --bumped-version as a no-op: when there are no substantive unreleased commits, git cliff may return the currently released version instead of exiting non-zero, and the script now handles that gracefully to avoid failing CI runs.
Changes:
- Extend
compute_semver_version()to returnNonewhengit cliffoutputs the same version currently recorded inpyproject.toml. - Update the method docstring to document the additional “no-op” condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
If there are no substantive commits, git cliff doesn't bump the version, but the script worked on the assumption there is always a change.
🚨 Breaking Changes🔥 Motivation
To avoid having red builds (despite not being of any relevance to the package).
🔨 Test Plan
🔗 Related issues/PRs