Repository navigation
Preserve source identity and null examples during document processing - #702
Open
daveshanley wants to merge 7 commits into
Open
daveshanley wants to merge 7 commits into
daveshanley wants to merge 7 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 315 315
Lines 39762 39755 -7
=========================================
- Hits 39762 39755 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
daveshanley
marked this pull request as ready for review
November 8, 2026 16:06
A caller that missed the remote cache could win a fresh reservation after another fetch had already published its file and retired its waiter. It then fetched again and replaced the published file. Recheck the cache under the new reservation, matching the local loader. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Null examples now reach the XML renderer as nil. Attributes and text nodes still went through fmt.Sprint and rendered "<nil>". Skip them, as null elements already are. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API documentation and retained-input analysis exposed three input-preservation defects: concurrent local opens could replace an existing parsed tree, nullable examples became the string "", and remote retrieval URLs could be mistaken for host overrides.
Validation: deterministic stale-miss and nullable-example regressions fail before their fixes. Exact retrieval-URL tests cover root-relative, scheme-relative, cross-origin, query, escaped-path and lazy-schema resolution. Independent adversarial testing verified 16 exact-URI cases and no unexpected fetches. Focused race tests pass. Owning-package tests cover the new fallback and local-pointer branches. Bunkhouse's full Doctor race suite passes against this source. Final-head CI passes Linux and Windows. CodeQL and both patch/project coverage checks pass.
Risk: medium. URI resolution, concurrent cold-load publication and generated values are shared library behavior. Explicit BaseURL host override and $self precedence remain covered. No new public option, permission rule or cached hot-path work is added. Bare external named-anchor handling is an existing limitation outside this repair. No merge or release is included.