Repository navigation
docs: condition-set hierarchy and opt-in deletion in env copy - #671
Open
CarlosMion wants to merge 5 commits into
Open
CarlosMion wants to merge 5 commits into
CarlosMion wants to merge 5 commits into
Conversation
Environment copy now keeps each condition set's parent (PER-15750, permitio/permit-backend#3387). Document what that changes for API callers: a scope that copies a child but not its parent is refused with 409, overwrite re-parents existing target sets, a broken source hierarchy is refused with 406, and the new delete_target_only_condition_sets option with its matching rules, permission and policy-guard refusal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for permitio-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Scope patterns match case-sensitively with * as the only wildcard, and include patterns are ORed (permitio/permit-backend#3387 makes the copy do this; it used ILIKE and ANDed includes, and the page cited fnmatch). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…r object permitio/permit-backend#3387 checks every guarded object a copy would change or delete, as the API does for a direct change, instead of refusing only the condition-set deletion option on a guarded target. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Granting a permission and adding a condition set rule need the guard's permission; a refused copy names the object; an unreachable guard is a 503; async errors are in the task result. - A copied child is moved out from under a deleted set, not a 409. - A cycle among sets selected for deletion is a 406. - Flag the scope-matching change for existing callers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The API now asks the Policy Guard before it starts the async copy, so an unreachable guard answers 503 on the request; a 403 is still in the task result. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(PER-15750): condition-set hierarchy, an opt-in
delete_target_only_condition_sets, exact scope matching, andper-object Policy Guard checks on a copy.
doesn't have yet.
Changes
All changes are in
docs/manage-your-account/creating-environments.mdx:including granting a permission and adding a condition set rule;
403naming the object; an unreachable guard fails it with503;on the async endpoint either error is in the task result;
overwritealso replaces a condition set's parent; neither strategy deletestarget-only condition sets.
scopethat copies a child but not its parent is refused with409;overwritere-parents existing target sets;406.true only of
custom_policies. It now states the real rules:*is the only wildcard, matching iscase-sensitive, includes are ORed. The fnmatch note stays, scoped to
custom_policies, which really uses it.A "Changed matching" note tells existing callers what now selects differently.
it deletes, how a copied child is moved out from under a deleted set, the cascade
409, the406for a cycleamong the sets to delete, the permission and guard checks it needs, and that it has no effect on a new target.
No changelog entry:
updates-and-feedback/changelog.mdxlists release sources rather than entries.Test plan
mastercopy fails the same check (the page's tables use the repo'scompact style), so I didn't reformat it.
🤖 Generated with Claude Code