[FEATURE] Prometheus: add request headers and query params interpolation#638
Merged
Conversation
AntoineThebaud
changed the title
jgbernalp
force-pushed
the
add-request-interpolation
branch
from
c9e5e5d to
672fe74
Compare
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
jgbernalp
force-pushed
the
add-request-interpolation
branch
2 times, most recently
from
f6a3669 to
b73eb75
Compare
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
jgbernalp
force-pushed
the
add-request-interpolation
branch
from
b73eb75 to
b7dbfd1
Compare
| newEntries.forEach(({ key, value }) => { | ||
| if (key !== '') { | ||
| newParams[key] = value; | ||
| const parts = value.split(','); |
Contributor
There was a problem hiding this comment.
Not sure if this is an issue in practice: What if value is a single value which contains a comma (but should not be an array)?
Contributor
Author
There was a problem hiding this comment.
I'll check to adjust the component in a follow up PR so we can deal with values that have commas internally
andreasgerstmayr
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Part of: perses/perses#3940
Needs: perses/shared#118
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.