Feat/unix sockets - #1329
Conversation
|
|
There was a problem hiding this comment.
this have to be added to the ci suite as new entry otherwise it won't run
There was a problem hiding this comment.
Do you mean explicitly to be added to the ci.yaml file as another script to run?
| cat > "$CONFIG" <<EOF | ||
| [general] | ||
| auth_type = "trust" | ||
|
|
||
| [[databases]] | ||
| name = "pgdog" | ||
| host = "$SOCKET_DIR" | ||
| port = $PG_PORT | ||
| database_name = "pgdog" | ||
| user = "pgdog" | ||
| EOF |
There was a problem hiding this comment.
let's just create the config file like most other tests do, I think we use just default static values there
| # --- 1. Build pgdog ----------------------------------------------------------- | ||
| echo "==> building pgdog" | ||
| cargo build --manifest-path "$ROOT/Cargo.toml" --bin pgdog |
There was a problem hiding this comment.
verify the shared logic for integration tests - we have common scripts that will run and wait the pgdog available
| } | ||
|
|
||
| infer_region_from_rds_host(&addr.host).ok_or_else(|| { | ||
| let host = addr.host.tcp().expect("Host must be a TCP address"); |
There was a problem hiding this comment.
avoid panics in the runtime code until it's 100% justified
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
3 participants
This PR is still in its preliminary stage but the basic function works with unix sockets on the backend.