Allow Symfony 8 in frankenphp-symfony#193
Closed
turegjorup wants to merge 1 commit into
Closed
Conversation
php-runtime#185 updated the Symfony constraints to include ^8.0 across the monorepo but missed src/frankenphp-symfony/composer.json, so runtime/frankenphp-symfony (including the 1.0.0 release tagged after that PR) cannot be installed alongside Symfony 8. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Author
|
Closing — this duplicates #192 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#185 updated the Symfony version constraints to include
^8.0across the monorepo, butsrc/frankenphp-symfony/composer.jsonwas missed — soruntime/frankenphp-symfony(including the 1.0.0 release tagged after that PR) cannot be installed alongside Symfony 8:This adds
|| ^8.0to the three constraints, matching what #185 did for the other packages (frankenphp-symfonyappears to be the only remaining straggler — all other subpackages already allow^8.0).Tested against a Symfony 8.1 application running on FrankenPHP 1.12 in worker mode.