Document DelayedTargetValidation attribute (PHP 8.5)#5457
Open
jordikroon wants to merge 3 commits intophp:masterfrom
Open
Document DelayedTargetValidation attribute (PHP 8.5)#5457jordikroon wants to merge 3 commits intophp:masterfrom
jordikroon wants to merge 3 commits intophp:masterfrom
Conversation
Contributor
Author
|
I can't assign reviewers. But I think it's best if @DanielEScherzer takes a good look at this for completeness. |
Member
DanielEScherzer
left a comment
DanielEScherzer
left a comment
There was a problem hiding this comment.
looks correct to me, a few suggestions
lacatoire
reviewed
Apr 5, 2026
lacatoire
reviewed
Apr 5, 2026
lacatoire
reviewed
Apr 5, 2026
Co-authored-by: Louis-Arnaud <la.catoire@gmail.com>
| ]]></programlisting> | ||
|
|
||
| <simpara> | ||
| When the attribute is instantiated via reflection using |
Member
There was a problem hiding this comment.
we should somehow clarify that "the attribute" here means the other attribute applied in the same location
lacatoire
reviewed
Apr 24, 2026
Comment on lines
+15
to
+18
| When applied to a declaration, any invalid usage of internal attributes | ||
| on the same target will not trigger a compile time error. Instead, the | ||
| validation is deferred and performed when the attribute is accessed via | ||
| the Reflection API. |
Member
There was a problem hiding this comment.
Suggested change
| When applied to a declaration, any invalid usage of internal attributes | |
| on the same target will not trigger a compile time error. Instead, the | |
| validation is deferred and performed when the attribute is accessed via | |
| the Reflection API. | |
| When applied to a declaration, any invalid usage of internal attributes | |
| on the same target will not trigger a compile time error. Instead, the | |
| validation is deferred and performed when the attribute is instantiated | |
| via <link linkend="reflectionattribute.newinstance">ReflectionAttribute::newInstance()</link>. |
Member
There was a problem hiding this comment.
ReflectionClass::getAttributes() alone does not trigger validation: the deferred check only fires on ReflectionAttribute::newInstance() (see Zend/zend_compile.c:7874-7930, where the error is stored on attr->validation_error and only rethrown by newInstance()).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document DelayedTargetValidation attribute that was introduced in PHP 8.5.
Ref: #4886