ext/intl: Sync IntlTimeZone object errors for invalid display types

[LamentXU123]

Now, IntlTimeZone::getDisplayName() handled invalid display_type values before fetching the object, so it only updated the global intl error state.

That is,

<?php
$tz = IntlTimeZone::createTimeZone('Europe/Lisbon');
var_dump($tz->getDisplayName(false, -1));
var_dump(intl_get_error_message());
var_dump($tz->getErrorCode());
var_dump($tz->getErrorMessage());

returns

bool(false)
string(76) "IntlTimeZone::getDisplayName(): wrong display type: U_ILLEGAL_ARGUMENT_ERROR"
int(0)
string(12) "U_ZERO_ERROR"

but I expect

bool(false)
string(76) "IntlTimeZone::getDisplayName(): wrong display type: U_ILLEGAL_ARGUMENT_ERROR"
int(1)
string(44) "wrong display type: U_ILLEGAL_ARGUMENT_ERROR"

The solution is to move TIMEZONE_METHOD_FETCH_OBJECT after the intl_errors_set func being called. So the object error state is correctly changed.

[devnexen]

good, the fix looks correct. it is consistent with intltz_has_same_rules.

One thing to note in the description: fetching before the display-type check means an unconstructed IntlTimeZone now throws Found unconstructed IntlTimeZone instead
of returning false. Only reachable via newInstanceWithoutConstructor(), and it's arguably more correct, so fine for 8.4, just worth stating it's intentional.

[LamentXU123]

Ah got it. Thanks for reviewing!