Fix #14499: Mark Lua::__construct $lua_script_file parameter as optional#5571
Merged
staabm merged 1 commit intophpstan:2.1.xfrom Apr 29, 2026
Merged
Fix #14499: Mark Lua::__construct $lua_script_file parameter as optional#5571staabm merged 1 commit intophpstan:2.1.xfrom
staabm merged 1 commit intophpstan:2.1.xfrom
Conversation
predictor2718
force-pushed
the
fix-14499
branch
from
b475b95 to
35727d1
Compare
VincentLanglet
approved these changes
Apr 29, 2026
staabm
approved these changes
Apr 29, 2026
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lua::__constructinresources/functionMap.phpincorrectly marked$lua_script_fileas required, causing a false positive "Class Lua constructor invoked with 0 parameters, 1 required." Fix: add=suffix to make the parameter optional, matching the PHP documentation and phpstorm-stubs definition.Closes phpstan/phpstan#14499