Repository navigation
[highlights] fix github-dark-default parameter, member, and JSX = colors - #1218
Merged
ije merged 1 commit intoOct 23, 2026
Merged
Conversation
…olors `github-dark-default` is the only GitHub theme ported from MordFustang21/zed-github-dark, and three tokens resolved differently from GitHub's own TextMate theme (Shiki's `github-dark-default`) and from the other bundled GitHub themes: - Parameters fell back to `variable`, the text color. GitHub colors TS/JS `variable.parameter` orange. - `property` was orange. GitHub colors member access through `variable.other`, the text color; its TextMate theme has no rule for the scopes Zed maps to `property`. - The JSX attribute `=` fell back to `punctuation`, the text color. GitHub colors it as `keyword.operator.assignment`, red. `property` and `variable.parameter` are each one token across languages, so CSS property names (blue in GitHub's theme) and Python parameters (text color there) still differ, as they already do in `github-light-default`, `github-dark-dimmed`, and the high-contrast themes.
|
@liby is attempting to deploy a commit to the Pierre Computer Company Team on Vercel. A member of the Team first needs to authorize it. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes three entries in
packages/highlights/themes/github-dark-default.jsonso that the theme colors these tokens the way Shiki'sgithub-dark-defaultdoes:github-dark-defaulta.b)=In Highlights,
propertyandvariable.parameterare each a single token shared by every language, so two cases still differ from Shiki. CSS property names are blue in Shiki; this change moves them from orange to the text color. Python parameters use the text color in Shiki and are orange after this change.github-light-default,github-dark-dimmed, and both high-contrast themes already color these two cases this way.Before
After
Motivation & Context
In
@pierre/diffs, the theme namegithub-dark-defaultloads Shiki's TextMate theme under the Shiki highlighter and this Zed port underpreferredHighlighter: 'highlights', so switching to Highlights changes the colors above for the same theme.The port comes from MordFustang21/zed-github-dark, while the other GitHub themes come from PyaeSoneAungRgn/github-zed-theme. It has no
variable.parameterorpunctuation.delimiter.jsxentry, so both tokens fell back to the text color. Its orangepropertyentry was added in #1166, but GitHub's TextMate theme has no rule for the scopes Zed maps toproperty: it colors member access throughvariable.other, which uses the text color.This change also makes
github-dark-defaultagree withgithub-light-default. When the two were used as a light/dark pair, parameters and members swapped colors between modes.Type of changes
first discussed with the dev team and they should be aware that this PR is
being opened
You must have first discussed with the dev team and they should be aware
that this PR is being opened
Checklist
contributing guidelines
moon run root:lint)moon run root:format)moonx diffs:test)moonx highlights:testpasses as well (2027 tests).How was AI used in generating this PR
Claude Code (Claude Fable and Claude Opus) compared the theme against Shiki's GitHub themes and the other bundled GitHub themes, made the change, rendered the screenshots with a script, ran the checks, and drafted this description. I reviewed the change and the screenshots.
Related issues
None.