Repository navigation
fix(diffs): remove empty <pre> in cleanUp so a StrictMode remount renders - #1219
Merged
Merged
Conversation
…ders FileDiff and File left an empty <pre> in the shadow root when cleanUp ran before the highlighter was ready. React StrictMode remounts onto the same container, hydrate() adopted the empty <pre>, and the code stayed blank. cleanUp now removes a <pre> with no children. Adds reactStrictMode.test.ts (fails on main: FileDiff 0/6, File 0/4).
|
@arthtyagi is attempting to deploy a commit to the Pierre Computer Company Team on Vercel. A member of the Team first needs to authorize it. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
Good catch, and thanks for the PR! I made a few small tweaks to it and added some more tests, cheers! |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Diff view was rendering blank for us under StrictMode with the header off. cleanUp now drops the empty pre so the remount renders.
Motivation & Context
Repro: https://github.com/arthtyagi/pierre-diffs-strictmode-repro (open in StackBlitz: https://stackblitz.com/github/arthtyagi/pierre-diffs-strictmode-repro)
Type of changes
Checklist
--type-aware)test/reactStrictMode.test.ts: fails on main, FileDiff 0/6 and File 0/4; passes with the fix)bun testinpackages/diffs: 2440 pass, 0 fail)How was AI used in generating this PR
Claude Code helped me build the repro and draft the fix + test; I reviewed it and ran the suite.
Related issues
Related: #478, #887