Skip to content

DM: Remove broken docs links#22840

Merged
ti-chi-bot[bot] merged 5 commits into
pingcap:masterfrom
dveeden:dm_docs_broken_links
May 20, 2026
Merged

DM: Remove broken docs links#22840
ti-chi-bot[bot] merged 5 commits into
pingcap:masterfrom
dveeden:dm_docs_broken_links

Conversation

@dveeden
Copy link
Copy Markdown
Contributor

@dveeden dveeden commented Apr 30, 2026

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dveeden dveeden requested review from alastori, hfxsd and qiancai April 30, 2026 09:00
@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 30, 2026
@dveeden
Copy link
Copy Markdown
Contributor Author

dveeden commented Apr 30, 2026

Maybe more of the v5.x and earlier things for DM should be removed?

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes outdated links to archived DM documentation and updates the note regarding DM versioning history. A suggestion was made to further simplify the explanation of the version jump from v2.0 to v5.3 to improve readability and reduce wordiness in accordance with the style guide.

Comment thread dm/dm-overview.md Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Comment thread dm/dm-overview.md

Before v5.4, the DM documentation is independent of the TiDB documentation. To access these earlier versions of the DM documentation, click one of the following links:

- [DM v5.3 documentation](https://docs-archive.pingcap.com/tidb-data-migration/v5.3/)
Copy link
Copy Markdown
Collaborator

@qiancai qiancai May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links are broken now because of a bug in the website-docs repo. Let me try fixing it.
fix DM archive URL resolution by qiancai · Pull Request #698 · pingcap/website-docs

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dveeden FYI, these broken links are fixed now. Could we revert the removal of these lines in this PR?

Comment thread dm/dm-overview.md
Comment thread dm/dm-overview.md Outdated
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 20, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 20, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-05-20 06:46:55.429578578 +0000 UTC m=+333144.933709254: ☑️ agreed by hfxsd.

@hfxsd hfxsd added translation/no-need No need to translate this PR. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. lgtm and removed missing-translation-status This PR does not have translation status info. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 20, 2026
@hfxsd
Copy link
Copy Markdown
Collaborator

hfxsd commented May 20, 2026

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label May 20, 2026
@ti-chi-bot ti-chi-bot Bot merged commit 5d9ab62 into pingcap:master May 20, 2026
11 of 12 checks passed
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #22915.
But this PR has conflicts, please resolve them!

ti-chi-bot Bot pushed a commit that referenced this pull request May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/dm lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants