tiup: document Prometheus external labels#23358
Conversation
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughDocuments the TiUP ChangesTiUP external labels documentation
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
First-time contributors' checklist
What is changed, added or deleted? (Required)
This PR documents TiUP support for
monitoring_servers[].external_labels.It updates the TiUP cluster and DM topology references to describe the new field, its validation rules, and a minimal example. It also adds a dedicated section to the monitoring customization guide to explain how TiUP renders
external_labelsduringdeploy,scale-out,scale-in, andreload.The compatibility note is explicit: older TiUP versions do not ignore this unknown field. They fail to parse the topology file.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
prometheus.ymlfor Prometheus tiup#1795AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit