Skip to content

i18n(ja): use English admonition labels so callouts render correctly - #23384

Closed
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-admonition-labels-english
Closed

i18n(ja): use English admonition labels so callouts render correctly#23384
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-admonition-labels-english

Conversation

@yahonda

@yahonda yahonda commented Jul 30, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

The machine-translation pipeline left some callout (admonition) labels in Japanese: > **注記**, > **警告**, > **ヒント**. Unlike the English markers, these Japanese labels are not picked up as the localized callout box, so they render as plain bold text instead of the Note/Warning/Tip box.

This PR reverts those labels to the English form so the site renders and localizes them correctly, matching the English source at the same position — preserving each page's exact colon form (**Note:** / **Note** / **Note**:, etc.).

  • 86 labels across 38 files (注記→Note, 警告→Warning, ヒント→Tip).
  • Author templates under resources/doc-templates/ are intentionally left as-is (their labels carry (オプション) and are meta-instructions, not published content).

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from: N/A (Japanese-only rendering fix; no English source change)
  • Other reference link(s): part of the ja i18n-ja-release-8.5 machine-translation cleanup series

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

…orrectly

The machine translation left some callout labels in Japanese (> **注記** /
> **警告** / > **ヒント**). Unlike the English markers, these do not render as
the localized callout box, so revert them to the English label matching the
English source at the same position (preserving each page's exact colon form:
**Note:** / **Note** / **Note**:). 86 labels across 38 files. Author templates
under resources/doc-templates/ are left as-is.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@ti-chi-bot ti-chi-bot Bot added the area/develop This PR relates to the area of TiDB App development. label Jul 30, 2026
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fc3bb1ba-fcd6-42e8-b2e6-28dbd1ac3d95

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kissmydb for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 30, 2026
@yahonda yahonda closed this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/develop This PR relates to the area of TiDB App development. missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant