Skip to content

spfresh: add protobuf definitions#416

Merged
Lloyd-Pottiger merged 2 commits into
pingcap:masterfrom
Lloyd-Pottiger:ningjie/spfreshpb
Jun 12, 2026
Merged

spfresh: add protobuf definitions#416
Lloyd-Pottiger merged 2 commits into
pingcap:masterfrom
Lloyd-Pottiger:ningjie/spfreshpb

Conversation

@Lloyd-Pottiger

@Lloyd-Pottiger Lloyd-Pottiger commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Adds TiPB protobuf definitions and generated bindings for SPFresh search, teardown, and search diagnostic stats.

What is changed and how it works?

  • Add proto/spfresh_search.proto and proto/spfresh_teardown.proto.
  • Add SPFresh search diagnostic stats fields.
  • Add generated Go bindings and update scripts/proto.lock.
  • Remove the branch-local src/lib.rs lint allowances for static_mut_refs and unused_imports so the crate root stays aligned with upstream.

Validation

  • make rust

Note on removed lint allowances

#![allow(static_mut_refs)] suppresses Rust 2024 compatibility warnings emitted by protobuf-generated Rust code such as instance.get(...) against mutable statics. The normal Rust CI path still passes without it. #[allow(unused_imports)] was not needed in the current code path; RUSTFLAGS=-Dunused-imports passed for both protobuf-codec and prost-codec checks.

@pingcap-cla-assistant

pingcap-cla-assistant Bot commented Jun 12, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger Lloyd-Pottiger merged commit c544c98 into pingcap:master Jun 12, 2026
4 checks passed
@Lloyd-Pottiger Lloyd-Pottiger deleted the ningjie/spfreshpb branch June 12, 2026 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants