-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(web): customize diff colors and markers #7347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SunkenInTime
wants to merge
14
commits into
pingdotgg:main
Choose a base branch
from
SunkenInTime:t3code/add-diff-appearance-settings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
57dedf1
feat(web): customize diff colors and markers
SunkenInTime dc4a888
test(desktop): cover diff appearance settings
SunkenInTime 053c326
fix(web): apply diff palette across diff chrome
SunkenInTime 5a4b464
fix(web): keep diff palette mapping in sync
SunkenInTime 05096bd
refactor(web): trim diff appearance settings
SunkenInTime 413b495
fix(web): preserve diff toggle interaction
SunkenInTime af66c02
refactor(web): reuse diff preview in appearance settings
SunkenInTime ecd0ba5
fix(web): align diff appearance controls
SunkenInTime 13f3b9f
fix(web): move diff settings into typography
SunkenInTime 53d6903
fix(web): keep terminal preview with monospace setting
SunkenInTime bc594cc
fix(web): apply diff palette to change counts
SunkenInTime 0c1e164
fix(web): color pull request diff totals
SunkenInTime b0c6753
fix(web): apply diff palette globally
SunkenInTime 60a1e37
Merge remote-tracking branch 'upstream/main' into t3code/add-diff-app…
SunkenInTime File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that
DiffAppearanceSyncputs--t3-diff-*on<html>, this label andPullRequestDiffStatfollow the setting — but the two hand-rolled+N / −Mstats do not:Sidebar.tsx:1543-1544(text-emerald-600 dark:text-emerald-400/text-red-600 dark:text-red-400) andGitActionsControl.tsx:1939-1941plus the totals at1952-1957(text-success/text-destructive). Before this PR every diff stat was consistently red/green; with Orange and blue selected the sidebar thread rows and the commit sheet stay green/red beside blue/orange stats everywhere else.Smallest fix: swap those four class strings for
text-[var(--t3-diff-addition-color,var(--success))]/text-[var(--t3-diff-deletion-color,var(--destructive))], or renderDiffStatLabelat those call sites so the palette has one owner.Posted via Macroscope — UI Consistency