fix(packaging): install AUR launcher icons where icon themes look - #7421
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6780762 to
e850b31
Compare
e850b31 to
b72d9d8
Compare
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This PR only modifies AUR packaging scripts to fix icon installation - no application runtime code is affected. The change simplifies the build by using bundled icons from the app package at sizes supported by icon themes (≤512x512) instead of downloading a non-standard 1024x1024 icon. You can add or adjust custom eligibility rules. Learn more. |
## What's Changed * feat(web): show project location in new thread picker by @StiensWout in pingdotgg/t3code#7392 * fix(packaging): install AUR launcher icons where icon themes look by @AugusDogus in pingdotgg/t3code#7421 * fix(web): label pull request merge actions by @tarik02 in pingdotgg/t3code#7381 * fix(server): avoid PRs inherited from default upstreams by @gsimone in pingdotgg/t3code#7317 * fix(desktop): stop the passkey dialog from popping as soon as sign-in opens by @t3dotgg in pingdotgg/t3code#7437 ## New Contributors * @AugusDogus made their first contribution in pingdotgg/t3code#7421 **Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260818.1127...v0.0.34-nightly.20260818.1128 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260818.1128
What Changed
t3code-binandt3code-nightly-bininstall the launcher icon from the AppImage's own hicolor icon set (16-512px, named per package) instead of a separately downloaded 1024px PNGpackaging/aur/scripts/release.shno longer fetches the icon asset or manages its checksumWhy
Since the AUR recipes moved in-repo (#4128), the launcher icon has been installed only under
usr/share/icons/hicolor/1024x1024/apps/. hicolor-icon-theme registers sizes only up to 512x512, and freedesktop icon lookup never scans unregistered directories, so GNOME and KDE show a generic icon for every nightly published since 2026-08-15. The previous out-of-repo recipe had the same 1024 path but was masked by a legacy/usr/share/pixmapscopy that the rewrite dropped.The AppImage payload already ships the channel-correct icon pre-rendered at every registered hicolor size (the same set electron-builder's deb/rpm targets install), so the packages now reuse it and the extra download goes away.
Verified by building both packages and running GTK icon-theme lookups against the extracted contents (previously NOT FOUND at every size, now resolving 16 through 512), plus a live before/after on Arch + GNOME with a fully stock configuration.
UI Changes
Before (published
t3code-nightly-bin0.0.34_nightly.20260818.1124-1) / after:Implemented with Claude Fable 5 in Claude Code.
Note
Install AUR launcher icons from AppImage hicolor directories instead of a single downloaded PNG
squashfs-root/usr/share/icons/hicolor/*/apps/and install them into matching hicolor size directories, so icon themes can find them.Macroscope summarized b72d9d8.
Note
Low Risk
Packaging-only changes to icon install paths and release checksum updates; no runtime app or auth logic touched.
Overview
Fixes missing launcher icons on GNOME/KDE by stopping installation of a separately downloaded 1024×1024 PNG (a size hicolor themes do not register) and copying every
hicolor/*/apps/t3code.pngfrom the extracted AppImage into the package at the matching theme sizes (t3code.png/t3code-nightly.png).Both
t3code-binandt3code-nightly-binPKGBUILDs drop the extra iconsourceentry and checksum;release.shno longer fetches the repo icon asset or patches its SHA256 inPKGBUILD.Reviewed by Cursor Bugbot for commit b72d9d8. Bugbot is set up for automated code reviews on this repo. Configure here.