Skip to content

fix(packaging): install AUR launcher icons where icon themes look - #7421

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
AugusDogus:t3code/fix-nightly-aur-icon
Aug 18, 2026
Merged

fix(packaging): install AUR launcher icons where icon themes look#7421
maria-rcks merged 1 commit into
pingdotgg:mainfrom
AugusDogus:t3code/fix-nightly-aur-icon

Conversation

@AugusDogus

@AugusDogus AugusDogus commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

What Changed

  • t3code-bin and t3code-nightly-bin install the launcher icon from the AppImage's own hicolor icon set (16-512px, named per package) instead of a separately downloaded 1024px PNG
  • packaging/aur/scripts/release.sh no longer fetches the icon asset or manages its checksum

Why

Since the AUR recipes moved in-repo (#4128), the launcher icon has been installed only under usr/share/icons/hicolor/1024x1024/apps/. hicolor-icon-theme registers sizes only up to 512x512, and freedesktop icon lookup never scans unregistered directories, so GNOME and KDE show a generic icon for every nightly published since 2026-08-15. The previous out-of-repo recipe had the same 1024 path but was masked by a legacy /usr/share/pixmaps copy that the rewrite dropped.

The AppImage payload already ships the channel-correct icon pre-rendered at every registered hicolor size (the same set electron-builder's deb/rpm targets install), so the packages now reuse it and the extra download goes away.

Verified by building both packages and running GTK icon-theme lookups against the extracted contents (previously NOT FOUND at every size, now resolving 16 through 512), plus a live before/after on Arch + GNOME with a fully stock configuration.

UI Changes

Before (published t3code-nightly-bin 0.0.34_nightly.20260818.1124-1) / after:

Screenshot From 2026-08-18 12-55-27 Screenshot From 2026-08-18 12-58-28

Implemented with Claude Fable 5 in Claude Code.

Note

Install AUR launcher icons from AppImage hicolor directories instead of a single downloaded PNG

  • Both t3code-bin PKGBUILD and t3code-nightly-bin PKGBUILD now extract icons from the AppImage's squashfs-root/usr/share/icons/hicolor/*/apps/ and install them into matching hicolor size directories, so icon themes can find them.
  • Removes the separately downloaded 1024x1024 icon PNG from the source arrays and their sha256sum entries.
  • The release.sh script no longer fetches the icon asset or updates its checksum in PKGBUILD during release.

Macroscope summarized b72d9d8.


Note

Low Risk
Packaging-only changes to icon install paths and release checksum updates; no runtime app or auth logic touched.

Overview
Fixes missing launcher icons on GNOME/KDE by stopping installation of a separately downloaded 1024×1024 PNG (a size hicolor themes do not register) and copying every hicolor/*/apps/t3code.png from the extracted AppImage into the package at the matching theme sizes (t3code.png / t3code-nightly.png).

Both t3code-bin and t3code-nightly-bin PKGBUILDs drop the extra icon source entry and checksum; release.sh no longer fetches the repo icon asset or patches its SHA256 in PKGBUILD.

Reviewed by Cursor Bugbot for commit b72d9d8. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f34bd4a1-05f6-4da6-84c4-486148aab673

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 18, 2026
@AugusDogus
AugusDogus force-pushed the t3code/fix-nightly-aur-icon branch 2 times, most recently from 6780762 to e850b31 Compare August 18, 2026 18:13
@github-actions github-actions Bot added size:S 10-29 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 18, 2026
@AugusDogus
AugusDogus force-pushed the t3code/fix-nightly-aur-icon branch from e850b31 to b72d9d8 Compare August 18, 2026 18:15
@AugusDogus
AugusDogus marked this pull request as ready for review August 18, 2026 18:20
@macroscopeapp

macroscopeapp Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at b72d9d8

Macroscope's review found this PR approvable — This PR only modifies AUR packaging scripts to fix icon installation - no application runtime code is affected. The change simplifies the build by using bundled icons from the app package at sizes supported by icon themes (≤512x512) instead of downloading a non-standard 1024x1024 icon.

You can add or adjust custom eligibility rules. Learn more.

@maria-rcks
maria-rcks merged commit db0659f into pingdotgg:main Aug 18, 2026
21 of 22 checks passed
sheehanmunim added a commit to munimtechnologies/mtcode that referenced this pull request Aug 18, 2026
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 18, 2026
## What's Changed
* feat(web): show project location in new thread picker by @StiensWout in pingdotgg/t3code#7392
* fix(packaging): install AUR launcher icons where icon themes look by @AugusDogus in pingdotgg/t3code#7421
* fix(web): label pull request merge actions by @tarik02 in pingdotgg/t3code#7381
* fix(server): avoid PRs inherited from default upstreams by @gsimone in pingdotgg/t3code#7317
* fix(desktop): stop the passkey dialog from popping as soon as sign-in opens by @t3dotgg in pingdotgg/t3code#7437

## New Contributors
* @AugusDogus made their first contribution in pingdotgg/t3code#7421

**Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260818.1127...v0.0.34-nightly.20260818.1128

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260818.1128
frankdavidcorona pushed a commit to frankdavidcorona/t3code that referenced this pull request Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants