Skip to content

fix(web): show pointer cursor on PR rows and reactions - #7631

Open
BeeSting50 wants to merge 1 commit into
pingdotgg:mainfrom
BeeSting50:fix/pr-filter-tab-pointer-cursors
Open

fix(web): show pointer cursor on PR rows and reactions#7631
BeeSting50 wants to merge 1 commit into
pingdotgg:mainfrom
BeeSting50:fix/pr-filter-tab-pointer-cursors

Conversation

@BeeSting50

@BeeSting50 BeeSting50 commented Aug 20, 2026

Copy link
Copy Markdown

Problem

Pull request list rows and reaction controls remain clickable while showing the default cursor. The filter and detail tabs now use shared Button and Toggle primitives on current main, so those already show the correct pointer cursor.

Fix

  • show the pointer cursor on selectable pull request rows
  • show the pointer cursor on enabled reaction pills
  • show the pointer cursor on the add-reaction trigger and emoji picker options
  • preserve the default cursor for disabled reaction pills
  • add a focused regression test for selectable rows

Verification

  • node_modules/.bin/vp test run apps/web/src/components/pullRequest/PullRequestRow.test.tsx apps/web/src/components/pullRequest/pullRequestReactions.logic.test.ts (14 tests pass)
  • targeted formatting passes
  • git diff --check passes
  • web typecheck reaches two unrelated existing errors in electronPasskeys.test.ts (conditionalUI type mismatch)

Closes #7606

Built with GPT-5.6 Codex in the T3 Code harness.


Note

Low Risk
CSS-only cursor classes and a static HTML regression test; no behavior or data-path changes.

Overview
Extends pointer-cursor affordances on pull request UI so clickable controls no longer show the default arrow.

PullRequestRow row buttons get cursor-pointer so selectable list rows read as clickable. In PullRequestReactions, the same class is applied to existing reaction pills (when reacting is allowed), the “Add a reaction” trigger, and each emoji in the reaction picker.

A new PullRequestRow.test.tsx uses static markup to assert selectable rows include cursor-pointer.

Reviewed by Cursor Bugbot for commit eb57ab4. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add cursor-pointer to PullRequestRow and PullRequestReactionBar controls

Adds the cursor-pointer utility to the row button in PullRequestRow.tsx and to reaction pill buttons, the popover trigger, and emoji option buttons in PullRequestReactions.tsx. A test in PullRequestRow.test.tsx verifies the class is present. No logic or event handling changes.

Macroscope summarized eb57ab4.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0c291986-222a-4e1d-8162-5538db3813d4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 20, 2026

@macroscopeapp macroscopeapp Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One inconsistency: the condensed copy of the same tab strip in PullRequestDetailPanel.tsx still renders without a pointer cursor, so the tabs change cursor behavior depending on whether the header is condensed.

Posted via Macroscope — UI Consistency

Comment thread apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Aug 20, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at eb57ab4

Macroscope's review found this PR approvable — Adds cursor-pointer CSS styling to PR rows and reaction buttons - purely visual change with no runtime behavior impact. Includes a simple test to verify the styling.

You can add or adjust custom eligibility rules. Learn more.

@macroscopeapp
macroscopeapp Bot dismissed their stale review August 20, 2026 04:21

Dismissing prior approval to re-evaluate 51e2738

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Aug 20, 2026
@BeeSting50
BeeSting50 force-pushed the fix/pr-filter-tab-pointer-cursors branch from 51e2738 to eb57ab4 Compare August 20, 2026 04:26
@BeeSting50 BeeSting50 changed the title fix(web): show pointer cursor on remaining PR controls fix(web): show pointer cursor on PR rows and reactions Aug 20, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review August 20, 2026 04:26

Dismissing prior approval to re-evaluate eb57ab4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Pull request screens are missing pointer cursors on clickable elements

1 participant