Fixed: if Permalinks > Custom Base was previously modified with WooCommerce enabled, the view-product goal would wrongfully get a 2nd leading slash.#310
Conversation
…mmerce enabled, the view-product goal would wrongfully get a 2nd leading slash.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughIn ChangesWooCommerce Integration
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/Integrations/WooCommerce.php`:
- Around line 33-35: In the is_multisite() conditional block, apply the same
slash normalization to the $uri variable before concatenating it with
get_blog_details()->path. Use trim($uri, '/') to remove leading slashes from
$uri before the concatenation, which will prevent double slashes from being
created when the multisite path (which has a trailing slash) is joined with the
product base URI (which has a leading slash).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0b72d271-073f-406e-a71c-d76237d8dcd5
📒 Files selected for processing (1)
src/Integrations/WooCommerce.php
…mmerce enabled, the view-product goal would wrongfully get a 2nd leading slash.
Summary by CodeRabbit