Skip to content

Connect to configured remote browsers - #195

Merged
smnandre merged 3 commits into
playwright-php:mainfrom
gimler:feature/ws-endpoint
Nov 7, 2026
Merged

smnandre merged 3 commits into
playwright-php:mainfrom
gimler:feature/ws-endpoint

Conversation

@gimler

@gimler gimler commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Allow launch() to connect to a remote Playwright browser through wsEndpoint, configured directly, through the builder or from environment variables.

Document the separate-container setup, add a changelog entry and preserve positional logger compatibility.

Related to playwright-php/playwright-symfony#57.

@gimler

gimler commented Oct 30, 2026

Copy link
Copy Markdown
Contributor Author

depends on #186

@codecov

codecov Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@gimler

gimler commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

@kbond can you take a look please

@kbond

kbond commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Yep, just went through the bugs to create a bug fix release. Going to go through the features soon.

@kbond
kbond force-pushed the feature/ws-endpoint branch from 32a552a to f2fc291 Compare November 6, 2026 21:41
@kbond kbond changed the title feat: add wsEndpoint to PlaywrightConfig feat: connect to configured remote browsers Nov 6, 2026
@kbond

kbond commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

@gimler I added some tests and docs, can you take a look?

@kbond kbond changed the title feat: connect to configured remote browsers Connect to configured remote browsers Nov 7, 2026
@smnandre

smnandre commented Nov 7, 2026

Copy link
Copy Markdown
Member

With wsEndpoint set, launch() connects instead of launching, so launch-only options (headless, args, channel, executable path) are ignored without notice. A log warning or a documentation note would make that explicit.

connect() now always sends the configured context options, including on explicit connect() calls. Existing connect() callers get a context configured differently from before, which belongs in the changelog.

kbond commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Good catch. I clarified in the guide that browser launch options belong on the remote server. Configured context settings now apply only when launch() uses wsEndpoint. An explicit connect() still creates its initial context with Playwright defaults.

@kbond
kbond force-pushed the feature/ws-endpoint branch from fff402e to 5db81e4 Compare November 7, 2026 17:19

@smnandre smnandre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gimler and @kbond

@smnandre
smnandre merged commit b46c01f into playwright-php:main Nov 7, 2026
10 checks passed
@gimler
gimler deleted the feature/ws-endpoint branch November 8, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants