Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue
Closes #5786
Description of change
Avoid passing default
koptstocalc_fig_sync()andwrite_fig_from_object_sync()whenkaleido.start_sync_server()is running, preventing an unnecessaryUserWarning: The kopts argument is ignored if using a server.Demo
Testing strategy
Added unit tests
test_kaleido_sync_server_no_kopts_warningandtest_kaleido_get_opts_helperintests/test_optional/test_kaleido/test_kaleido.py. Verified that all 16 Kaleido tests pass cleanly.Additional information (optional)
Plotly sets
defaults.headers = {"X-Requested-With": "plotly.py"}by default to comply with OpenStreetMap tile policy. When Kaleido's sync server is running, options cannot be re-applied per request and Kaleido warns ifkoptsis provided._get_kaleido_opts()now avoids passing default headers when the sync server is running (while continuing to pass them when the server is stopped or when custom headers/options are configured), eliminating spurious warnings.Guidelines