(Sources-1) Teach SemanticIndex about NamespacedAccesses#1286
Open
DavisVaughan wants to merge 2 commits into
Open
(Sources-1) Teach SemanticIndex about NamespacedAccesses#1286DavisVaughan wants to merge 2 commits into
SemanticIndex about NamespacedAccesses#1286DavisVaughan wants to merge 2 commits into
Conversation
For tracking namespace accesses within a file, easing future lookup Use accessors
lionel-
approved these changes
Jun 24, 2026
| /// Namespaced access recorded during indexing, i.e. `package::symbol` or | ||
| /// `package:::symbol` | ||
| #[derive(Debug, Clone, PartialEq, Eq)] | ||
| pub struct NamespacedAccess { |
Contributor
There was a problem hiding this comment.
The "d" in namespaced kind of trips me up.
Can this be NamespaceAccess instead?
Comment on lines
+721
to
+724
| package: String, | ||
| symbol: String, | ||
| kind: NamespacedAccessKind, | ||
| offset: TextSize, |
Contributor
There was a problem hiding this comment.
This feels like a pure data carrier without any invariants to uphold, so I'd just make these pub, but I know you and I have different defaults on this matter ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress towards #1234
The
SemanticIndexnow records instances of::and:::in its CST walk.This is going to be useful as one of many ways to detect which packages are used by a workspace.
They are recorded as
Realllllly for package source requests we only need
package, but my hypothesis is that the rest of this information is going to be useful in the future as well, and I think they should be pretty small. And if you take a step back, it also seems like it would be a bit weird for theSemanticIndexto expose the package list, but not where it originated from.