-
Notifications
You must be signed in to change notification settings - Fork 28
add support for deploying to Posit Connect Cloud #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samperman
wants to merge
13
commits into
main
Choose a base branch
from
connect-cloud-auth-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e101baa
feat: add support for deploying to Posit Connect Cloud
samperman eb113c1
Merge remote-tracking branch 'origin/main' into connect-cloud
samperman 58e096c
fix: repair Connect Cloud log authorization on Python 3.8
samperman 95da59f
fix: make Connect Cloud token refresh failures actionable
samperman a3ef268
feat: select Posit Connect Cloud credentials by nickname only
samperman 159a22c
feat: keep Posit Connect Cloud credentials in the system keyring
samperman 25a7e97
refactor: share the 401 refresh-and-retry skeleton between both clients
samperman 9a5f49e
fix: restore Python 3.8 test collection for test_connect_cloud
samperman b9eaa4b
fix: restore fixture teardown order broken by the keyring conftest
samperman b0d4eab
fix: tell the keyring fixture's None marker from a deleted module entry
samperman 8ee4dce
test: cover the keyring fixture teardown branches
samperman 9018786
test: cover the unknown-nickname error from ServerStore.resolve
samperman 6465047
add support for -V to connect cloud deployments
samperman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,44 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |
|
|
||
| ## Unreleased | ||
|
|
||
| - Posit Connect Cloud is now a supported deployment target, alongside Posit | ||
| Connect and shinyapps.io, mirroring the R rsconnect package's support. | ||
| Register an account with `rsconnect add -n <nickname> --connect-cloud | ||
| -A <account>`, which verifies the account exists and that you can publish to | ||
| it. Authentication is an interactive browser login by default; for CI and | ||
| other non-interactive use, pass a service account credential with | ||
| `--client-id`/`--client-secret` (or the `CONNECT_CLOUD_CLIENT_ID` and | ||
| `CONNECT_CLOUD_CLIENT_SECRET` environment variables). Tokens are refreshed | ||
| automatically. Deploy with any `rsconnect deploy` subcommand by passing | ||
| `--connect-cloud` (or `-s connect.posit.cloud`) with `-A <account>` (or the | ||
| `CONNECT_CLOUD_ACCOUNT` environment variable; a `SHINYAPPS_ACCOUNT` variable | ||
| exported for shinyapps.io is ignored here), or `-n <nickname>` for a saved | ||
| credential — which publishes to the account it was saved with, or to another | ||
| account of the same login when `-A` is given as well. Supported content types: | ||
| Shiny (Python and R), Streamlit, Dash, Bokeh, Jupyter notebooks, Quarto, | ||
| R Markdown, and static content. | ||
|
Comment on lines
+14
to
+25
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think some of this detail is better left to the documentation rather than the changelog |
||
| - `rsconnect add` now reports invalid option combinations and unreadable | ||
| certificate files as plain error messages. Previously these surfaced as raw | ||
| Python tracebacks. | ||
| - Deploying with a nickname (`-n`) no longer fails when `SHINYAPPS_ACCOUNT`, | ||
| `SHINYAPPS_TOKEN`, or `SHINYAPPS_SECRET` happen to be set in the environment. | ||
| Those values are ignored for nickname deploys — the saved credential is what | ||
| the nickname means. A typed `-T/--token` or `-S/--secret` still conflicts with | ||
| `-n`. | ||
| - Credentials are now redacted from verbose (`-v`) log output and from error | ||
| messages that quote a request URL. This covers authorization and signing | ||
| headers, OAuth tokens and client secrets in request and response bodies, the | ||
| query-string credentials of presigned bundle-upload URLs, and the values of | ||
| environment variables passed with `-E` (names are still logged). | ||
| - `rsconnect deploy manifest` and `rsconnect deploy bundle` no longer overwrite | ||
| the title of existing content when `-t/--title` is not given. Previously a | ||
| redeploy reset the server-side title to one derived from the manifest or | ||
| bundle; now, as with the other deploy commands, a redeploy without `-t` | ||
| leaves the existing title unchanged. | ||
| - `rsconnect deploy pyproject` no longer uses the server nickname (`-n`) as a | ||
| title override. The title now comes from `-t/--title` or the pyproject | ||
| metadata, so redeploying with a nickname no longer renames existing content | ||
| after the nickname. | ||
| - Added support for Python 3.14. The test suite now runs on Python 3.14 in CI. | ||
| - `rsconnect deploy` subcommands now accept `--quiet`, which suppresses the | ||
| step-by-step progress lines and the streamed server build log, printing only | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.