Refactor watch tests to avoid using test.cb

[RyanZim]

#514 (comment)

[Copilot]

Pull request overview

Refactors watch tests from AVA callback APIs to async promises, supporting newer AVA versions.

Changes:

• Replaces test.cb and t.end.
• Adds promise-based process cleanup and assertions.
• Clarifies a dependency test name.

Suppressed comments (4)

test/watch.js:415

• Ignoring the promise returned by finally() creates an unhandled rejected promise whenever this test's deferred promise rejects. Run the cleanup through handlers for both fulfillment and rejection so the derived promise is handled.

    promise.finally(() => {
      try {
        if (processRunning) cp.kill()
      } catch {}
    })

test/watch.js:528

• Ignoring the promise returned by finally() creates an unhandled rejected promise whenever this test's deferred promise rejects. Run the cleanup through handlers for both fulfillment and rejection so the derived promise is handled.

      promise.finally(() => {
        try {
          if (processRunning) cp.kill()
        } catch {}
      })

test/watch.js:319

• Ignoring the promise returned by finally() creates an unhandled rejected promise whenever this test's deferred promise rejects. Run the cleanup through handlers for both fulfillment and rejection so the derived promise is handled.

    promise.finally(() => {
      try {
        if (processRunning) cp.kill()
      } catch {}
    })

test/watch.js:143

• finally() returns a new promise that preserves the original rejection. Since that returned promise is ignored, a failure also creates an unhandled rejection rather than only rejecting the promise awaited by AVA. Handle both outcomes explicitly when running the cleanup.

    promise.finally(() => {
      try {
        if (processRunning) cp.kill()
      } catch {}
    })

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.