Add fenicsx and simplified Landlab solvers - #889
Conversation
|
Thank you for the updates, @joargu! Since I see that the PR description is missing and the CI is failing, I marked this as draft. Let me know once you need a review, or if you need any help. |
uekerman
left a comment
uekerman
left a comment
There was a problem hiding this comment.
Thanks for the update!
Structure looks good, a few minor comments below. I have not yet run things, but I want to do so once the README is updated.
| self.status[1:-1, 1:-1] = self.CORE | ||
|
|
||
| # Have one open boundary on the south side | ||
| # rmg.set_closed_boundaries_at_grid_edges(True, True, True, False) |
There was a problem hiding this comment.
It's often better not to add commented-out code. This will soon be hard to understand.
| # order: right, top, left, bottom | ||
| self.status[:, -1] = self.CLOSED | ||
| self.status[-1, :] = self.CLOSED | ||
| self.status[:, 0] = self.CLOSED |
There was a problem hiding this comment.
seems like one of the four is missing
| for n1, n2 in self.links | ||
| ]) | ||
|
|
||
| internal_dt = 0.15 * self.dx * self.dx / np.nanmax(active_D) |
There was a problem hiding this comment.
What is the 0.15 here? Where does the value come from?
| repeats = int(dt // internal_dt) | ||
| remainder = dt - repeats * internal_dt |
There was a problem hiding this comment.
What are these lines doing? Please add comments.
3 participants
TODO: Summarize and motivate the changes, link to issues, remove the checklist entries that are not relevant.
Checklist
changelog-entries/<PRnumber>.md.requirements.txtfiles, I regenerated siblingrequirements-reference.txtfiles withpython3 tools/releasing/update-requirements-reference.py(pass a path to update only that directory, or--allto refresh everything).For new tutorials or tutorial cases:
README.mdmetadata.yamltools/tests/tests.yaml_config.yaml