perf(button): memoize icon, label and badge rendering#8530
Open
sudheerchauhan452-lab wants to merge 2 commits intoprimefaces:masterfrom
Open
perf(button): memoize icon, label and badge rendering#8530sudheerchauhan452-lab wants to merge 2 commits intoprimefaces:masterfrom
sudheerchauhan452-lab wants to merge 2 commits intoprimefaces:masterfrom
Conversation
Optimize Button component by memoizing icon, label and badge computations using React.useMemo. - Prevents unnecessary recalculations on re-renders - Improves performance in high-frequency render scenarios - Inlined helper logic to avoid hook dependency issues - Maintains full backward compatibility"
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
melloware
added
the
Type: Performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8526
Summary
This PR improves the performance of the Button component by memoizing the rendering of icon, label, and badge using
React.useMemo.Changes
Benefits
Testing
Notes
This change maintains full backward compatibility and does not alter the public API.