Skip to content

fix(release): bump-minor regenerates the lockfile#145

Open
wmadden-electric wants to merge 1 commit into
mainfrom
chore/bump-minor-lockfile
Open

fix(release): bump-minor regenerates the lockfile#145
wmadden-electric wants to merge 1 commit into
mainfrom
chore/bump-minor-lockfile

Conversation

@wmadden-electric

Copy link
Copy Markdown
Contributor

The v0.2.0 release PR (#143) failed every CI job at the install step: the bump rewrote the internal workspace:<version> pins in all 32 manifests, but pnpm-lock.yaml still recorded the old version, and CI installs with --frozen-lockfile.

This makes the release tooling regenerate the lockfile itself so the procedure can't miss it again:

  • scripts/bump-minor.ts now runs pnpm install --lockfile-only after stamping versions.
  • Adds the pnpm bump-minor script that both docs/oss/versioning.md and the publish-npm-version skill already referenced but which didn't exist.
  • The skill and versioning doc now state that the bump diff must include pnpm-lock.yaml and why.

Verified by running pnpm bump-minor on a clean checkout: the diff contains all 32 workspace package.json files plus pnpm-lock.yaml, and pnpm install --frozen-lockfile passes afterwards.

🤖 Generated with Claude Code

The v0.2.0 release PR (#143) went red across CI because the bump
rewrote workspace:<version> pins in every manifest but left
pnpm-lock.yaml at the old version, and CI installs with
--frozen-lockfile. bump-minor now runs `pnpm install --lockfile-only`
after set-version, the `pnpm bump-minor` script both docs already
reference actually exists, and the skill/versioning docs call out the
lockfile requirement.

Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c4cd9acb-297d-41b2-bcbe-fdafc4eb8082

📥 Commits

Reviewing files that changed from the base of the PR and between 6667b93 and 2efdce4.

📒 Files selected for processing (4)
  • docs/oss/versioning.md
  • package.json
  • scripts/bump-minor.ts
  • skills-contrib/publish-npm-version/SKILL.md

Summary by CodeRabbit

  • New Features

    • Added a command to streamline minor version updates across workspace packages.
    • Automatically regenerates the lockfile during version bumps.
  • Documentation

    • Clarified release procedures and publishing guidance, including lockfile requirements.
    • Added notes explaining that outdated lockfiles can cause CI validation failures.

Walkthrough

Added a bump-minor package script that runs the version bump utility. The utility now regenerates pnpm-lock.yaml with pnpm install --lockfile-only after updating workspace versions. Release documentation and publishing instructions now describe the lockfile update, --frozen-lockfile CI behavior, and the expected diff.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: bump-minor now regenerates the lockfile.
Description check ✅ Passed The description matches the changeset and explains the lockfile regeneration and related docs updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-minor-lockfile
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch chore/bump-minor-lockfile

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Jul 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@prisma/composer@145
npm i https://pkg.pr.new/@prisma/composer-prisma-cloud@145

commit: 2efdce4

@wmadden
wmadden enabled auto-merge (rebase) July 21, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants