fix(release): bump-minor regenerates the lockfile#145
Conversation
The v0.2.0 release PR (#143) went red across CI because the bump rewrote workspace:<version> pins in every manifest but left pnpm-lock.yaml at the old version, and CI installs with --frozen-lockfile. bump-minor now runs `pnpm install --lockfile-only` after set-version, the `pnpm bump-minor` script both docs already reference actually exists, and the skill/versioning docs call out the lockfile requirement. Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
Summary by CodeRabbit
WalkthroughAdded a 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
The v0.2.0 release PR (#143) failed every CI job at the install step: the bump rewrote the internal
workspace:<version>pins in all 32 manifests, butpnpm-lock.yamlstill recorded the old version, and CI installs with--frozen-lockfile.This makes the release tooling regenerate the lockfile itself so the procedure can't miss it again:
scripts/bump-minor.tsnow runspnpm install --lockfile-onlyafter stamping versions.pnpm bump-minorscript that bothdocs/oss/versioning.mdand thepublish-npm-versionskill already referenced but which didn't exist.pnpm-lock.yamland why.Verified by running
pnpm bump-minoron a clean checkout: the diff contains all 32 workspacepackage.jsonfiles pluspnpm-lock.yaml, andpnpm install --frozen-lockfilepasses afterwards.🤖 Generated with Claude Code