Preserve supervisor poison failures and register worker ownership - #67
Merged
Conversation
…-supervision-fixtures
…s-task-supervision-fixtures
sorenbs
marked this pull request as ready for review
September 9, 2026 19:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A panicking task builder poisons the registration lock after its task ID is assigned. Readiness, phase snapshots and subsequent registration must continue to fail rather than conceal that partial operation. Four method-scoped expectations now document those deliberate poison contracts; the new regression invokes a failing builder, checks every observation path and proves a later builder never runs.
The existing worker spawn has one statement-scoped expectation and an explicit source-owner registration. Its handle remains retained under the phase lock before shutdown can drain the task map. No production function body changes or poison-recovery fallback are introduced.
Completed local validation: common quality (12 syntax tests and 47 Python controls), all 15 task tests, 52 actual-source invariant tests with 1,024 property cases and 11 service invariant/Loom tests. All 13 exact-head CI checks pass, including the configured compiler, compatible Miri/corpus and actual-diff mutation gates. The changed source contains only explicit diagnostic ownership and the new fixture; the prerequisite cancellation mutation and compatible buffer checks already passed on #64, and are not relabeled as new local runs here.
Targets
slate; includes #64 and its prerequisites. Addresses five additional inherited warning occurrences, clears the remaining warnings insrc/tasks.rs, and prunes both active platform inventories plus the replaced legacy spawn entry. Shutdown-driver warnings insrc/tasks/shutdown.rsremain separate work. Immutable adoption inventories are unchanged.