Fix static p5 vector method

[Ayush4958]

Resolves #8930

Changes:

• In src/math/p5.Vector.js :- Properly bound _friendlyError & friendlyErrorsDisabled to the static Vector. Added early false after the friendly error is triggered. This prevents a secondary crash.

• Added a new unit test suite to ensure the static FES validation works.

Screenshots of the change:

PR Checklist

• npm run lint passes
• [Unit tests] are included / updated

[welcome]

🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors!
🤔 Please ensure that your PR links to an issue, which has been approved for work by a maintainer; otherwise, there might already be someone working on it, or still ongoing discussion about implementation. You are welcome to join the discussion in an Issue if you're not sure!
🌸 Once your PR is merged, be sure to add yourself to the list of contributors on the readme page !

Thank You!

[Ayush4958]

@ksen0
PR is ready for review

thnks ...

[p5-bot]

Continuous Release

CDN link

• https://raw.esm.sh/pr/p5@6403293/lib/p5.min.js

Published Packages

• https://pkg.pr.new/p5@6403293

Commit hash: e09e6f7

Previous deployments

---

This is an automated message.

[perminder-17]

Here we are defining the fes in the vector class and here p5._firendlyError is a global static.

What if we don't do this and everywhere in this file wherever this._friendlyError is called we replace it with p5._friendlyError it should work the same and could look a little cleaner?

It's similar to how setHeading() is in this file (line no. 2028)?

what you think?

[Ayush4958]

yeah, It works perfectly fine in codebase, cleaniness could be maintained and we dont have to create its duplicate method.

I could apply those changes, share ur thoughts on that

[ksen0]

please do @Ayush4958 thanks!

[Ayush4958]

@ksen0 @perminder-17
I was trying to implement planned changes in code, but it's throwing rerference p5 is not defined.
because vector sits above that wrapper, any code inside the class methods that tries to say p5._friendlyError will crash the entire library because p5 doesn't exist in that context.

we can go with the implementation I had proposed in PR

[perminder-17]

Yes, I now understand where this error is coming from. It didn't cause any problem in the browser, but as soon as I ran the tests, the error showed up.

So about the setHeading reference I shared earlier, that one is an instance method, so there too we should replace p5._friendlyError with this._friendlyError. That's the correct fix.

One more thing: I noticed the Matrix functions have the same issue.

p5.js/src/math/Matrices/Matrix.js

Line 249 in 76e4694

p5._friendlyError(

There as well, it's best to go through this instead of p5, because p5 isn't defined at the module level, which makes the bare p5._friendlyError unreliable.

You need to route the actual p5 friendly error here too, add Matrix.prototype._friendlyError = p5._friendlyError; inside matrix(p5, fn), so this._friendlyError in the Matrix methods works.

Also, very minor thing I noticed while looking at setHeading function,

p5.js/src/math/p5.Vector.js

Line 2026 in 76e4694

this._values instanceof Array && this._values.slice(2).some(v => v !== 0))

in vector calss we don't have anything called _values, in constructor we define values so, can you please replace this._values -> this.values wherever we had?

Thanks for your input on fixing them.

[Ayush4958]

@perminder-17 , I had cover all the fixing u mentioned, u can have look to it
@ksen0 , PR is ready for review

thanks ....