Fixed typo in quaternion multiplication#9010
Open
roymacdonald wants to merge 2 commits into
Open
Conversation
Continuous ReleaseCDN linkPublished PackagesCommit hash: 34809c3 Previous deploymentsThis is an automated message. |
ksen0
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the fix for #9006
There is a typo in the p5.Quat multiplication;
In line https://github.com/processing/p5.js/blob/main/src/webgl/p5.Quat.js#L44 where it reads this.vec.z - quat.vec.z it should be this.vec.z * quat.vec.z. It is just replacing the - for *.
It quite easy to verify agains the textbook quaternion multiplication.
I am not sure about the implications this has in p5, as of how extensively this has afected p5 in general.
Not sure either if there have been other fixes to compesate this error in other places of the math.