Skip to content

Fixed typo in quaternion multiplication#9010

Open
roymacdonald wants to merge 2 commits into
processing:mainfrom
roymacdonald:quaternion-mult-fix
Open

Fixed typo in quaternion multiplication#9010
roymacdonald wants to merge 2 commits into
processing:mainfrom
roymacdonald:quaternion-mult-fix

Conversation

@roymacdonald

Copy link
Copy Markdown

This is the fix for #9006

There is a typo in the p5.Quat multiplication;
In line https://github.com/processing/p5.js/blob/main/src/webgl/p5.Quat.js#L44 where it reads this.vec.z - quat.vec.z it should be this.vec.z * quat.vec.z. It is just replacing the - for *.
It quite easy to verify agains the textbook quaternion multiplication.
I am not sure about the implications this has in p5, as of how extensively this has afected p5 in general.
Not sure either if there have been other fixes to compesate this error in other places of the math.

@p5-bot

p5-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

Continuous Release

CDN link

Published Packages

Commit hash: 34809c3

Previous deployments

This is an automated message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants