fix: keep Download buttons on real file downloads - #713
Open
sharadvc wants to merge 1 commit into
Open
Conversation
Stop rewriting Linux snap assets to snapcraft.io install pages so Download CTAs serve files from GitHub releases. Prefer non-snap packages for the primary OS download button. Fixes processing#646 Co-authored-by: Sharad. <sharadvc@users.noreply.github.com>
✅ Deploy Preview for java-processing-faf822 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Homepage/nav already go to
/download. On the download page,.snapassets were rewritten to Snap Store install URLs, so Download-style buttons sent people to install flows instead of files.Stop those overrides (use GitHub release
downloadUrls) and prefer non-.snappackages for the primary OS download button when available.Fixes #646