Skip to content

Wave D: budget-below-timeout test, replay-fix lesson, nice-d pre-push, wave B follow-ups - #2056

Merged
remigiusz-antczak merged 1 commit into
mainfrom
land/wave-1026d3
Oct 27, 2026
Merged

remigiusz-antczak merged 1 commit into
mainfrom
land/wave-1026d3

Conversation

@remigiusz-antczak

Copy link
Copy Markdown
Collaborator

Summary

Wave D of the delivery-pipeline hardening, plus the review follow-ups from wave B.

  • scripts/test_budget_below_timeout.py: invariant test that every watchdog or wait budget stays below the hard timeout it runs under (CI job timeout-minutes vs inner step timeouts, heavy-slot lease wait vs merge-train gate). It fails when no inner timeouts are parsed, when a job has no timeout-minutes, and it ignores comment lines.
  • pre-push-verify.sh runs the local gate under nice -n 19; scripts/test_prepush_nice.py checks that the gate's exit codes (75, 124) survive the wrapper.
  • lane_guard.py: the shadow-fix closer also accepts issue URLs on any host (GitHub Enterprise included), anchored with a word boundary.
  • Recurring-failure rule: a fix for a recurring failure class is replayed against past instances before it is accepted, and change-carried signals (paths, default-off wording) win over labels. Prose in the pipeline-optimizer and retrospective references, plus an evals case.
  • test_security_gates_corpus.py: the guard scaling check flaked twice on CI runners at about 35x for a 10x input (80 ms vs 2.3 ms, 188 ms vs 5.3 ms). Profiling shows the guard is linear (growth exponent about 1.1, dominated by pure-Python shlex), so the fixed 30x ratio was measuring runner noise. The check now times the guard relative to an in-process shlex pass over the same blob and fails only when that relative cost grows more than 3x with size. An injected quadratic path is still caught (8.6x against 2.8x).
  • Wave B follow-ups: IndexError in test_prepush_gate_cache.py, closer regex widened beyond #N.

Verification

  • All scripts/ci-tests.d/*.sh pass locally; size ratchet passes vs main with documented markers.
  • One independent review pass: 0 red, 4 yellow, 1 blue; all folded into this commit.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Hi1ChtXVVrE8YEA2Ano93i

…, wave B review follow-ups

Agentic-delivery lessons: a watchdog or budget is shorter than the hard timeout it pre-empts
(scripts/test_budget_below_timeout.py over CI step, job and heavy-lease timeouts); a fix for a
recurring failure class is replayed against past instances and keyed on signals the change carries
(new eval case recurring-fix-replay-signals). Shared-host bullet in host-enforcement.md and the
pre-push gate now runs under nice -n 19 (scripts/test_prepush_nice.py).

Wave B follow-ups: test_prepush_gate_cache.py tolerates a blank shim log line and asserts the
stage_run.py wrapper line; lane_guard shadow-fix closer also matches Fixes <issue URL>.

Tests: all scripts/ci-tests.d/*.sh green

size-budget-raise: .claude/skills/agentic-delivery/references/pipeline-optimizer.md 17583→17784 one anti-stall rule
size-budget-raise: .claude/skills/agentic-delivery/references/retrospective.md 4577→4844 one paragraph on replaying fixes
size-budget-raise: .claude/skills/agentic-delivery/references/host-enforcement.md 42637→43026 one shared-host bullet

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hi1ChtXVVrE8YEA2Ano93i
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant