Migrate wasmtime to wasmtime-cpp-api#503
Merged
Merged
Conversation
leonm1
force-pushed
the
api/wasmtime
branch
3 times, most recently
from
40e3040 to
68ebe57
Compare
PiotrSikora
requested changes
Mar 2, 2026
Member
PiotrSikora
left a comment
PiotrSikora
left a comment
There was a problem hiding this comment.
Implements memory limiting and execution termination for wasmtime.
Could you split this off into a separate PR? I think it's just a few lines, so it should be doable, and I think those changes warrant a proper review instead of being bundled in this mass refactor. Thanks!
leonm1
force-pushed
the
api/wasmtime
branch
2 times, most recently
from
680dc57 to
5982aca
Compare
leonm1
force-pushed
the
api/wasmtime
branch
2 times, most recently
from
356f7e2 to
dbc1f3e
Compare
PiotrSikora
reviewed
Mar 12, 2026
PiotrSikora
reviewed
Mar 12, 2026
Member
PiotrSikora
left a comment
PiotrSikora
left a comment
There was a problem hiding this comment.
Uhm, looking at the passed arguments in failed tests, it seems like some endianness conversions are broken.
PiotrSikora
reviewed
Mar 14, 2026
leonm1
force-pushed
the
api/wasmtime
branch
2 times, most recently
from
ffe5499 to
c0fe685
Compare
martijneken
approved these changes
Apr 4, 2026
Contributor
martijneken
left a comment
martijneken
left a comment
There was a problem hiding this comment.
LGTM for correctness based on testing added in #525 and also a rigorous external e2e test suite. Please address style concerns when possible.
PiotrSikora
reviewed
Apr 20, 2026
PiotrSikora
reviewed
May 13, 2026
Hides many of the implementation details of the wasm-c-api.
Note: adds `wat` feature to wasmtime c headers to fix the following build error, but note that `wat` support is not enabled in the wasmtime build, this just adds the headers to allow the cpp api to compile.
```
external/com_github_bytecodealliance_wasmtime/crates/c-api/include/wasmtime/module.hh:39:17: error: use of undeclared identifier 'wat2wasm'
39 | auto wasm = wat2wasm(wat);
| ^
1 error generated.
```
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hides many of the implementation details of the wasm-c-api.
Required for implementing execution limits, as those are under the wasmtime_ c api, which is fully incompatible with stores created using the wasm_ c api. Execution limits implemented in #510.
Built off of #502.