Repository navigation
Fix hang with --dist=loadgroup if a crashed worker is replaced - #1324
Merged
RonnyPfannschmidt merged 2 commits intoAug 27, 2026
Merged
Conversation
radoering
force-pushed
the
fix-loadgroup-hang
branch
from
April 27, 2026 14:19
6c94249 to
25282ab
Compare
Contributor
Author
|
@RonnyPfannschmidt Since you approved the PR some time ago, I am wondering what is still preventing the merge? |
RonnyPfannschmidt
enabled auto-merge
August 26, 2026 15:09
RonnyPfannschmidt
disabled auto-merge
August 27, 2026 05:03
RonnyPfannschmidt
enabled auto-merge
August 27, 2026 05:04
Contributor
Author
|
@RonnyPfannschmidt Thanks for merging. 🙏 Maybe, if time permits you can take a look if #1328 is also an acceptable fix? (Different root cause, but similar consequences.) |
dwaynebailey
added a commit
to dwaynebailey/virtaal
that referenced
this pull request
Oct 11, 2026
pytest-xdist 3.8.0 puts every group a crashed worker had back on the queue, finished ones included. The replacement worker is sent a group with no tests left, never reports, and is never given more work, so test-macos hangs until its watchdog. Drop the finished groups first, as xdist does after 3.8.0 (pytest-dev/pytest-xdist#1324). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tooclassyforthisworld
pushed a commit
to tooclassyforthisworld/virtaal
that referenced
this pull request
Oct 12, 2026
pytest-xdist 3.8.0 puts every group a crashed worker had back on the queue, finished ones included. The replacement worker is sent a group with no tests left, never reports, and is never given more work, so test-macos hangs until its watchdog. Drop the finished groups first, as xdist does after 3.8.0 (pytest-dev/pytest-xdist#1324). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1323
In addition to the fix in
remove_node(), I added a sanity check in_assign_work_unit(). (Without the fix and the sanity check the unit test hangs. Without the fix but with the sanity check, it fails due to theRuntimeError.)