Fix more n plus 1 queries - #1638
Open
ChrisLovering wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for pydis-static ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ChrisLovering
force-pushed
the
fix-more-n-plus-1-queries
branch
from
July 25, 2026 20:00
30c1a47 to
23f75f9
Compare
|
coverage: 100.0%. remained the same — fix-more-n-plus-1-queries into main |
jchristgit
requested changes
Jul 27, 2026
jchristgit
left a comment
jchristgit
left a comment
Contributor
There was a problem hiding this comment.
The select related change in apps/staff/views.py looks good to me.
The cache functionality does not seem like a good idea to me, because the invalidation isn't bulletproof. If multiple HTTP workers cache the roles, and one of them creates or deletes a new role, then only that HTTP worker will have its cache cleared, the rest will keep running around with a stale cache.
The filter list test also seems unrelated. I do not mind, but why was this added?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.