Skip to content

fix(oidc): preserve Ping validation on refresh - #1899

Merged
nijel merged 1 commit into
python-social-auth:masterfrom
nijel:oidc-validate
Aug 6, 2026
Merged

fix(oidc): preserve Ping validation on refresh#1899
nijel merged 1 commit into
python-social-auth:masterfrom
nijel:oidc-validate

Conversation

@nijel

@nijel nijel commented Aug 6, 2026

Copy link
Copy Markdown
Member

Route Ping's provider-specific ID token decoding through the shared hook so refreshed tokens cannot bypass it. Retain the common authorized-party and access-token hash checks.

Route Ping's provider-specific ID token decoding through the shared hook so refreshed tokens cannot bypass it. Retain the common authorized-party and access-token hash checks.
@nijel nijel self-assigned this Aug 6, 2026
@nijel
nijel enabled auto-merge (rebase) August 6, 2026 10:04
@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.23%. Comparing base (d56fe6d) to head (a7876ef).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
social_core/backends/ping.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1899      +/-   ##
==========================================
+ Coverage   87.17%   87.23%   +0.05%     
==========================================
  Files         352      352              
  Lines       13624    13637      +13     
  Branches      671      672       +1     
==========================================
+ Hits        11877    11896      +19     
+ Misses       1504     1495       -9     
- Partials      243      246       +3     
Flag Coverage Δ
unittests 87.23% <93.33%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nijel
nijel merged commit 956ffc4 into python-social-auth:master Aug 6, 2026
18 checks passed
@nijel
nijel deleted the oidc-validate branch August 6, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant