Skip to content

test(bootstrapper): prevent unintended background downloads - #1348

Merged
mergify[bot] merged 1 commit into
python-wheel-build:mainfrom
booxter:sandbox-test-retries
Sep 28, 2026
Merged

mergify[bot] merged 1 commit into
python-wheel-build:mainfrom
booxter:sandbox-test-retries

Conversation

@booxter

@booxter booxter commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Pull Request Description

What

Tests replacing PrepareSource.run() do not consume background results.
Disable background work too so placeholder URLs never trigger requests.

Why

This becomes important in sandboxed environments where network requests
don't quickly return an error but instead go into a backoff retry loop.

Tests replacing PrepareSource.run() do not consume background results.
Disable background work too so placeholder URLs never trigger requests.

This becomes important in sandboxed environments where network requests
don't quickly return an error but instead go into a backoff retry loop.

Co-Authored-By: OpenAI Codex <codex@openai.com>
Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
@booxter
booxter requested a review from a team as a code owner September 27, 2026 18:57
@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: python-wheel-build/fromager/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: f5e9d5e7-d5d4-4c26-95e8-eb1622c9711c

📥 Commits

Reviewing files that changed from the base of the PR and between e724cb4 and 77b7bc7.

📒 Files selected for processing (2)
  • tests/test_bootstrapper.py
  • tests/test_bootstrapper_iterative.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Six bootstrapper tests now mock PrepareSource.background_work to return None. The existing PrepareSource.run mock remains in the multiple-version failure-continuation test.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 77b7b

These test-only stubs prevent background work in the affected tests without changing production behavior. No concrete regression remains identified, so the change appears mergeable subject to normal checks.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: preventing unintended background downloads in bootstrapper tests.
Description check ✅ Passed The description explains the test change and its purpose. It matches the changeset and PR objectives.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify mergify Bot added the ci label Sep 27, 2026

@rd4398 rd4398 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix

@mergify
mergify Bot merged commit cc3b9c4 into python-wheel-build:main Sep 28, 2026
39 checks passed
@mergify

mergify Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants