test(bootstrapper): prevent unintended background downloads - #1348
Conversation
Tests replacing PrepareSource.run() do not consume background results. Disable background work too so placeholder URLs never trigger requests. This becomes important in sandboxed environments where network requests don't quickly return an error but instead go into a backoff retry loop. Co-Authored-By: OpenAI Codex <codex@openai.com> Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: python-wheel-build/fromager/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughSix bootstrapper tests now mock Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to These test-only stubs prevent background work in the affected tests without changing production behavior. No concrete regression remains identified, so the change appears mergeable subject to normal checks. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
Pull Request Description
What
Tests replacing PrepareSource.run() do not consume background results.
Disable background work too so placeholder URLs never trigger requests.
Why
This becomes important in sandboxed environments where network requests
don't quickly return an error but instead go into a backoff retry loop.