Skip to content

fix(resolver): log wheel-only candidate skips at INFO - #1354

Merged
mergify[bot] merged 1 commit into
python-wheel-build:mainfrom
ryanpetrello:fix/wheel-only-log-level
Oct 2, 2026
Merged

mergify[bot] merged 1 commit into
python-wheel-build:mainfrom
ryanpetrello:fix/wheel-only-log-level

Conversation

@ryanpetrello

Copy link
Copy Markdown
Contributor

Lower the verbosity of routine candidate skips without generating noisy WARNING telemetry events.

In complex runs of fromager, especially ones in multi-version mode, this logger.warn() call results in an extremely verbose amount of output (roughly 80% of WARN level output).

Also, this message reports candidate filtering, not a failed resolution, so WARN is excessive.

@ryanpetrello
ryanpetrello requested a review from a team as a code owner October 2, 2026 10:19
@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 17 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: python-wheel-build/fromager/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 9ccbff2d-de16-4daf-b3b7-da8c9ff8e8d5

📥 Commits

Reviewing files that changed from the base of the PR and between eb0642f and e263ce9.

📒 Files selected for processing (2)
  • src/fromager/resolver.py
  • tests/test_resolver.py

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: python-wheel-build/fromager/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 86066700-3715-4324-b16f-75b05261763b

📥 Commits

Reviewing files that changed from the base of the PR and between 27db2d6 and eb0642f.

📒 Files selected for processing (2)
  • src/fromager/resolver.py
  • tests/test_resolver.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

PyPIProvider.find_matches now logs at INFO when it skips a wheel-only version. Tests verify the INFO-level record and confirm that versions with an sdist or versions outside the requirement specifier do not produce a matching log message.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: ⚪ Minimal · up to eb064

The change lowers routine wheel-only skip messages to INFO while preserving the skip behavior. No actionable merge risk is indicated.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: logging wheel-only candidate skips at INFO level.
Description check ✅ Passed The description explains why routine wheel-only candidate skips should use INFO instead of WARNING and matches the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify mergify Bot added the ci label Oct 2, 2026
Keep routine candidate skips in CI logs without sending WARNING telemetry events.

Co-Authored-By: Codex <codex@openai.com>
Signed-off-by: Ryan Petrello <rpetrell@redhat.com>
@ryanpetrello
ryanpetrello force-pushed the fix/wheel-only-log-level branch from bc79044 to e263ce9 Compare October 2, 2026 11:02

@rd4398 rd4398 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@mergify
mergify Bot merged commit 3d0038c into python-wheel-build:main Oct 2, 2026
39 checks passed
@mergify

mergify Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants