Repository navigation
fix(deps): read pyproject.toml with tomllib instead of tomlkit - #1357
Conversation
get_pyproject_contents() only reads [build-system], so it does not need tomlkit's format-preserving parser. tomlkit (0.15.1) rejects some spec-valid files that re-open a super-table out of order, failing builds for affected packages (e.g. geventhttpclient). stdlib tomllib parses them correctly and is always available (Python >= 3.12). Co-Authored-By: Claude <claude@anthropic.com> Closes: python-wheel-build#1356 Signed-off-by: Christian Heimes <cheimes@redhat.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The parser change addresses valid TOML files rejected by the previous parser. No merge-blocking issue is established. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pull Request Description
What
get_pyproject_contents() only reads [build-system], so it does not need tomlkit's format-preserving parser. tomlkit (0.15.1) rejects some spec-valid files that re-open a super-table out of order, failing builds for affected packages (e.g. geventhttpclient). stdlib tomllib parses them correctly and is always available (Python >= 3.12).
Why
Closes: #1356