gh-153903: Use @ctypes.util.wrap_dll_function() with pythonapi#154030
Merged
Conversation
Use the @ctypes.util.wrap_dll_function() decorator with ctypes.pythonapi to wrap Python C API functions in the test suite.
Member
Author
ZeroIntensity
left a comment
Member
There was a problem hiding this comment.
The readability improvement is really nice
Member
Author
Readability is nice, but my first motivation is correctness. The new syntax reduces the risk of typo when declaring a ctypes function. |
vstinner
enabled auto-merge (squash)
July 19, 2026 10:14
Member
Author
Ah, test_logging failed. I just re-ran the job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the
@ctypes.util.wrap_dll_function()decorator with ctypes.pythonapi to wrap Python C API functions in the test suite.ctypesfunction pointers #153903