[CI] Make workflow/step names more consistent - #16177
Merged
Merged
Conversation
AlexWaygood
reviewed
Aug 10, 2026
| @@ -1,4 +1,4 @@ | |||
| name: Run mypy_primer | |||
| name: Mypy Primer | |||
Member
There was a problem hiding this comment.
I think the official name of the tool is mypy_primer -- I can't see any references to "Mypy Primer" in the README!
Collaborator
Author
There was a problem hiding this comment.
That was mostly an aesthetic choice to match the other names. Not married to it, although I would recommend starting with an uppercase letter.
Member
There was a problem hiding this comment.
I think we should use the styling projects use for themselves. mypy_primer appears to never be capitalized and always uses an underscore (ty has similar styling FWIW 😄)
This comment has been minimized.
This comment has been minimized.
srittau
marked this pull request as ready for review
August 10, 2026 12:45
Collaborator
Author
|
CI failures are unrelated. |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
AlexWaygood
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm sometimes confused about what each test does, because the names aren't always that clear. This is an attempt to improve this, but all further suggestions welcome!
Before:
After: