[django-import-export] Fix prefly tests - #16195
Merged
Merged
Conversation
The base classes of `ExportActionModelAdmin` are incompatible in the implementation when using Python >= 3.12. pyrefly flags this, but we can't do anything about it in the type stubs.
AlexWaygood
approved these changes
Aug 12, 2026
AlexWaygood
left a comment
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
Curious how this happened -- was the immediate trigger that upstream django-stubs changed? Or is pyrefly unpinned in our CI?
Collaborator
Author
This is what I think. A new version was released two hours ago. That version has different branches for Python 3.12+ and below. I didn't check, but wouldn't be surprised if these branches were new in this version. Also we curiously did |
Member
|
who knows what |
Collaborator
Author
Yeah, not a fan of that error code, especially when it's not commented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base classes of
ExportActionModelAdminare incompatible in the implementation when using Python >= 3.12. pyrefly flags this, but we can't do anything about it in the type stubs.Fixes CI errors on main.