Repository navigation
Change type read-only attributes from @property to Final - #16554
Open
crypt0lith wants to merge 1 commit into
Open
crypt0lith wants to merge 1 commit into
crypt0lith wants to merge 1 commit into
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: scipy-stubs (https://github.com/scipy/scipy-stubs)
+ tests/misc/test_submodules_empty.pyi:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
|
Member
|
Final also means they can't be overridden in subclasses. Is that accurate for these attributes? |
Contributor
Author
|
Python does not prohibit them from being overridden, but doing so causes Python to disagree with the C implementation: >>> class Meta(type):
... __base__ = str
... __basicsize__ = \
... __dictoffset__ = \
... __flags__ = \
... __itemsize__ = \
... __weakrefoffset__ = 42
... __text_signature__ = "hello"
...
>>> class Foo(metaclass=Meta):
... pass
...
>>> print(
... *(
... (getattr(Foo, attr), type.__dict__[attr].__get__(Foo, Meta))
... for attr in [
... "__base__",
... "__basicsize__",
... "__dictoffset__",
... "__flags__",
... "__itemsize__",
... "__weakrefoffset__",
... "__text_signature__",
... ]
... ),
... sep="\n",
... )
(<class 'str'>, <class 'object'>)
(42, 16)
(42, -1)
(42, 22044)
(42, 0)
(42, -32)
('hello', None)So
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #16549