Skip to content

Qualcomm AI Engine Direct - Updating Claude skill for new op development#19302

Open
qti-horodnic wants to merge 1 commit into
pytorch:mainfrom
CodeLinaro:skill
Open

Qualcomm AI Engine Direct - Updating Claude skill for new op development#19302
qti-horodnic wants to merge 1 commit into
pytorch:mainfrom
CodeLinaro:skill

Conversation

@qti-horodnic
Copy link
Copy Markdown
Contributor

@qti-horodnic qti-horodnic commented May 5, 2026

Summary

Updated the Claude skill for adding new op support based on my findings from manually implementing ~15 previous ops, including corner cases, bugs I've run into before and comments I've gotten on previous prs.

Test plan

Implemented the tan op using this skill only: #19301

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 5, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19302

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 7 Unrelated Failures

As of commit 00fa742 with merge base 08b2987 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 5, 2026
@qti-horodnic
Copy link
Copy Markdown
Contributor Author

@pytorchbot label "release notes: qualcomm"

@pytorch-bot pytorch-bot Bot added the release notes: qualcomm Changes to the Qualcomm backend delegate label May 5, 2026
@shewu-quic shewu-quic requested a review from psiddh May 15, 2026 02:51
@qti-horodnic
Copy link
Copy Markdown
Contributor Author

@psiddh
Thanks for the review and approval, I think you might need to merge these prs manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: qualcomm Changes to the Qualcomm backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants