NXP backend: Enable Add Tensor with new Neutron flow#19550
Open
roman-janik-nxp wants to merge 1 commit into
Open
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19550
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 348f0e9 with merge base 90a7cdb ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ec35724 to
81ce9b6
Compare
81ce9b6 to
d163471
Compare
Collaborator
Author
novak-vaclav
suggested changes
May 14, 2026
Contributor
novak-vaclav
left a comment
There was a problem hiding this comment.
Just a few comments and questions, otherwise good job! 😊
Collaborator
Author
|
EDIT: Some computation errors were caused by old NSYS version 3.4. Pushing passing tests with NSYS 3.7. |
8dac17c to
04c47ac
Compare
MartinPavella
approved these changes
May 20, 2026
04c47ac to
9cd39f7
Compare
|
robert-kalmar
approved these changes
May 22, 2026
9cd39f7 to
348f0e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add tests verifying correct support for add.tensor by the Neutron backend using the new Neutron MLIR flow.
Test plan
Unit tests provided.
cc @robert-kalmar