Skip to content

NXP backend: Enable Add Tensor with new Neutron flow#19550

Open
roman-janik-nxp wants to merge 1 commit into
pytorch:mainfrom
nxp-upstream:feature/nxg11066/EIEX-850-Add-support-for-add-support-using-new-Neutron-flow
Open

NXP backend: Enable Add Tensor with new Neutron flow#19550
roman-janik-nxp wants to merge 1 commit into
pytorch:mainfrom
nxp-upstream:feature/nxg11066/EIEX-850-Add-support-for-add-support-using-new-Neutron-flow

Conversation

@roman-janik-nxp
Copy link
Copy Markdown
Collaborator

@roman-janik-nxp roman-janik-nxp commented May 13, 2026

Summary

Add tests verifying correct support for add.tensor by the Neutron backend using the new Neutron MLIR flow.

Test plan

Unit tests provided.

cc @robert-kalmar

@roman-janik-nxp roman-janik-nxp added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels May 13, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 13, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19550

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 348f0e9 with merge base 90a7cdb (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 13, 2026
@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-850-Add-support-for-add-support-using-new-Neutron-flow branch from ec35724 to 81ce9b6 Compare May 13, 2026 22:00
@roman-janik-nxp roman-janik-nxp changed the title Test Add Tensor with new Neutron flow NXP backend: Enable Add Tensor with new Neutron flow May 14, 2026
@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-850-Add-support-for-add-support-using-new-Neutron-flow branch from 81ce9b6 to d163471 Compare May 14, 2026 14:05
@roman-janik-nxp
Copy link
Copy Markdown
Collaborator Author

@novak-vaclav

Copy link
Copy Markdown
Contributor

@novak-vaclav novak-vaclav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments and questions, otherwise good job! 😊

Comment thread backends/nxp/tests/ir/converter/node_converter/test_add_tensor_converter.py Outdated
Comment thread backends/nxp/tests/ir/converter/node_converter/test_add_tensor_converter.py Outdated
@roman-janik-nxp
Copy link
Copy Markdown
Collaborator Author

roman-janik-nxp commented May 18, 2026

Waiting on update to NC 3.1.1 to push the last changes.

EDIT: Some computation errors were caused by old NSYS version 3.4. Pushing passing tests with NSYS 3.7.

@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-850-Add-support-for-add-support-using-new-Neutron-flow branch 2 times, most recently from 8dac17c to 04c47ac Compare May 19, 2026 13:17
Comment thread backends/nxp/tests/ir/converter/node_converter/test_add_tensor_converter.py Outdated
Comment thread backends/nxp/tests/ir/converter/node_converter/test_add_tensor_converter.py Outdated
Comment thread backends/nxp/tests/ir/converter/node_converter/test_add_tensor_converter.py Outdated
Comment thread backends/nxp/tests/ir/converter/node_converter/test_add_tensor_converter.py Outdated
@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-850-Add-support-for-add-support-using-new-Neutron-flow branch from 04c47ac to 9cd39f7 Compare May 22, 2026 12:47
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented May 22, 2026

CLA Not Signed

@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-850-Add-support-for-add-support-using-new-Neutron-flow branch from 9cd39f7 to 348f0e9 Compare May 22, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants